Make NetCDF the Default Format for CRTM LUTs (v3.2.0)#291
Make NetCDF the Default Format for CRTM LUTs (v3.2.0)#291BenjaminTJohnson wants to merge 1 commit intodevelopfrom
Conversation
|
This requires A LOT of testing and integration checks in FV3-JEDI / UFO workflows. |
| Default_MWwaterCoeff_File = TRIM(ADJUSTL(File_Path)) // TRIM(Default_MWwaterCoeff_File) | ||
| END IF | ||
|
|
||
| ! Smart detect SpcCoeff format if not specified |
There was a problem hiding this comment.
This could be adopted for all LUTs, to get ride of format specification.
There was a problem hiding this comment.
Thanks for this effort!
All tests passed and it looks good to me.
Meanwhile, I wonder if the merge of this PR into dev will perhaps break UFO, could initiate a collaborative PR merge with https://github.com/JCSDA-internal/ufo/pull/3825, in which the coefficient format argument is added in UFO. But, with the smart format detection in CRTM_Lifecycle, we probably won't need these any more.
In any case, ShihWei could probably help test this NetCDF feature in UFO. weiwilliam
|
I am glad to see that this effort is happening! |
Description
This PR updates the CRTM to use NetCDF as the default format for all Look-Up Table (LUT) interfaces (Aerosol, Cloud, Spectral, Transmittance, and Emissivity), replacing the legacy Binary default. This aligns the codebase with modern data standards while maintaining robust backward compatibility for legacy binary datasets.
Key Changes
Default Format Switch:
netCDFas the default format for all coefficient types..ncequivalents.TauCoeff_IO.f90,AerosolCoeff_IO.f90) to prioritize NetCDF when format flags are unspecified.Robust Backward Compatibility (Smart Detection):
CRTM_Init. The system now automatically checks for the existence of SpcCoeff/TauCoeff files. If the default (NetCDF) file is missing but a legacy Binary file exists, it seamlessly falls back to Binary format. This ensures that existing user applications and regression tests relying on binary data continue to work without modification.Default_File_Pathlogic to properly utilize theFile_Pathargument as a fallback for NetCDF loading whenNC_File_Pathis not provided.Test Suite Updates:
netCDF=.FALSE.to preserve the validity of binary IO unit tests.New Utilities:
TauCoeff_Inspecttool for inspecting Transmittance Coefficient files.Testing
ctest -j4: 100% Passed (193/193 tests).