Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

fix input input conflict #10

Open
TaylorHey wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix input input conflict #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions game.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,12 +180,16 @@ function getKey(value){
return null;
}

var CanPressButton = true


addEventListener("keydown", function (e) {
var lastKey = getKey(e.keyCode);
if (['up', 'down', 'left', 'right'].indexOf(lastKey) >= 0
&& lastKey != inverseDirection[snake.direction]) {
if (['up', 'down', 'left', 'right'].indexOf(lastKey) >= 0
&& lastKey != inverseDirection[snake.direction] && CanPressButton) {
snake.direction = lastKey;
} else if (['start_game'].indexOf(lastKey) >= 0 && game.over) {
CanPressButton = false // disable input until next frame
} else if (['start_game'].indexOf(lastKey) >= 0 && game.over) {
game.start();
}
}, false);
Expand All @@ -205,7 +209,8 @@ function loop() {
}
setTimeout(function() {
requestAnimationFrame(loop);
}, 1000 / game.fps);
}
CanPressButton = true // reenable input for next frame NOTE: This is a bandaid fix I devised with about 3 hours of JS knowledge, it doesn't actually address the root problem.
}, 1000 / game.fps); // Ideally there would be a queue system to store the second input instead of dropping it entirely if there is two inputs on the same frame but I have no idea how to do that yet
} // Maybe I'll be back in a few months once I've finished this course to actually fix it, but at least right now instead of randomly dying, the game just drops the second input :p

requestAnimationFrame(loop);