Fix TSTMstStgs settings callback leak#87
Open
appaKappaK wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #82
Fixes a KSPCF-reported memory leak where destroyed
TSTMstStgsinstances remain subscribed toGameEvents.OnGameSettingsApplied.Root Cause
TSTMstStgs.Start()subscribesApplySettingstoGameEvents.OnGameSettingsApplied, butOnDestroy()was adding the callback again instead of removing it. SinceTSTMstStgsis created for every scene, destroyed instances could accumulate as event callback owners across scene changes.Changes
ApplySettingsfromGameEvents.OnGameSettingsAppliedinOnDestroy()TSTMstStgs.Instancewhen the destroyed object is the active singletonValidation
Built and tested locally in KSP. After scene changes and roughly 2 hours of play, the previous KSPCF
TarsierSpaceTech:TSTMstStgs/OnGameSettingsAppliedwarning did not reappear.