Whatsapp imported file error fixed #11
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Prashun123 Thanks for the PR! This does fix the bug, but, will also cause the program to not recognize the previous formats (try running the tests). Also, while creating the dictionary maintain a separate variable for time format, and set this variable to the appropriate value depending on whether there is an ampm in Finally, you can check whether the fix worked or not by running the tests :) |
This was referenced Dec 9, 2021
|
@Prashun123 Any updates on this? |
|
Sir, there were some submissions which incorporated the date and time issue more correctly, so I thought to start work on other issue's. |
|
#10 Is currently is focused on fixing the dates, you can continue working on this if you want :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
The error we received while using the imported file of Whatsapp is fixed, it was giving some error due to some regex expressions, but they are fixed now.