Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edit] FirestorePostViewModel & FirestoreDrinkViewModel 뷰모델 리팩토링중 #142 #148

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

bdrsky2010
Copy link
Contributor

개요 (이슈 번호 및 요약)

변경 사항 (작업 내용)

오타수정

  • Drink.Swift
struct Drink {
	let agePrefence: AgePreference -> let agePreference: AgePreference
}

FirebaseDrinkViewModel 메서드 추가 구현

  • func fetchDrinkDocument(ref: CollectionReference, drinkID: String) async throws -> Drink
  • func fetchTaggedPosts(ref: CollectionReference) async -> [Post]

FirebasePostViewModel 메서드 전달인자 타입 변경

  • 변경 전 func fetchPostDocument(ref: CollectionReference) async throws -> Post 변경 후 func fetchPostDocument(document: DocumentReference) async throws -> Post
  • func fetchPostField(ref: CollectionReference) async throws -> PostField 변경 후 func fetchPostField(document: DocumentReference) async throws -> PostField

@bdrsky2010 bdrsky2010 requested review from Phangg and withseon March 7, 2024 15:31
@bdrsky2010 bdrsky2010 self-assigned this Mar 7, 2024
@bdrsky2010 bdrsky2010 added the 수정 코드 리팩토링 수행 label Mar 7, 2024
@withseon
Copy link
Contributor

withseon commented Mar 7, 2024

확인 완료 -- 🥂

@Phangg
Copy link
Member

Phangg commented Mar 8, 2024

ㅎㅎㅎㅎ 좋아요-👏

@bdrsky2010 bdrsky2010 merged commit f449c05 into develop Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
수정 코드 리팩토링 수행
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants