[Edit] RecordView/PostsView 관련 코드 수정 #166 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RecordViewModel의 recordPostDataClear() 호출 코드 작성 - ChangeUserNameView의 button disable 조건 변경 - PostDetailView 내 ToolbarItem 수정 추가 - post upload를 위해 guard let 구문 주석 처리
- Firestorage upload 시 폴더링을 적용해주었는데, imageURL fetch 시 적용하지 않았기 때문에 발생한 문제 - fetchImageURL() 매개변수를 받아서 경로를 설정하도록 코드 수정 - 파일 경로에 따라 StorageReference를 반환하는 getStorageRoute() 생성
- Post 데이터 모델에 likedCount 추가 - PostCell 게시글 좋아요 액션 likeAction() 메서드로 분리
- "술상올리기"의 task 내에서 호출 - 주석 수정
withseon
force-pushed
the
refactoring/RecordView
branch
from
1a44008 to
db0f404
Compare
bdrsky2010
reviewed
Mar 21, 2024
| } label: { | ||
| Image(systemName: isLike ? "heart.fill" : "heart") | ||
| .foregroundStyle(isLike ? .mainAccent01 : .gray01) | ||
| } | ||
| Text(Formatter.formattedPostLikesCount(likeCount)) | ||
| .foregroundStyle(.gray01) | ||
| .onTapGesture { |
There was a problem hiding this comment.
likeAction() 함수 호출을 두 군데에서 하는 건 좋지 않아보여서 다른 방법을 같이 찾아보는게 낫겠습니다.
There was a problem hiding this comment.
Button과 Text 두 개가 같이 눌릴 수 있다는 점은 미처 생각하지 못했네요 ㅠㅠ
코드는 원복하겠습니다 ~~
좋아요 버튼 크기에 대한 불편함을 해결하는 방법에 대해서는 같이 얘기해봐요 -! 🥂
|
확인했어요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요 (이슈 번호 및 요약)
변경 사항 (작업 내용)
RecordView
PostsView / AuthenticatedMypageView
PostCell
PostDetailView
ChangeUserNameView
FireStorageService
Post Model
스크린샷
특이사항 (트러블 슈팅 과정 및 참고 자료 등)