Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring] CustomDialog 시 ToolBarItem disabled, AddTagView/SearchTagView RatingDialog 문제 #185

Merged
merged 3 commits into from
May 21, 2024

Conversation

withseon
Copy link
Contributor

@withseon withseon commented May 7, 2024

개요 (이슈 번호 및 요약)

변경 사항 (작업 내용)

  1. CustomDialog가 띄워질 때 ToolBarItem disabled 처리
  2. RecordViewModel 의 isShowRatingDialog 삭제 및 AddTagView, SearchTagView에 각각 isShowRatingDialog 상태 프로퍼티 추가

스크린샷

특이사항 (트러블 슈팅 과정 및 참고 자료 등)

withseon added 2 commits May 1, 2024 23:56
- CustomDialog 나타날 때, ToobarItem disabled 처리
- SearchTagViw(sheet) 내려갈 때, isShowRatingDialog 값 변경
…178

*문제 및 원인*
RecordViewModel 내에 isShowRatingDialog 프로퍼티를 AddTagView, SearchTagView에서 사용함으로 발생한 문제
- AddTagView와 SearchTagView 각각 isSowRatingDialog를 따로 가지고 있게 코드 수정
@withseon withseon changed the title Refactoring/custom dialog [Refactoring] CustomDialog 시 ToolBarItem disabled, AddTagView/SearchTagView RatingDialog 문제 May 7, 2024
@withseon withseon self-assigned this May 7, 2024
@withseon withseon added the 수정 코드 리팩토링 수행 label May 7, 2024
@ha-nabi
Copy link

ha-nabi commented May 8, 2024

고생하셨네요 ^^

@Phangg
Copy link
Member

Phangg commented May 8, 2024

확인이요! 고생했어요 😄

@withseon withseon merged commit 64ccb03 into develop May 21, 2024
@withseon withseon deleted the refactoring/CustomDialog branch May 21, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
수정 코드 리팩토링 수행
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants