Update main table colors

[LoayGhreeb]

Follow-up to: #11510. Closes LoayGhreeb#8.
Before:

After:

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[Siedlerchr]

Please either make them derived or add some new constants, as this makes it easier for dark theme to change the colors

[koppor]

Carl and I are on it.

[koppor]

Using this gray-blue colors looks odd:

[koppor]

Blue berry:

[koppor]

With -jr-theme:

[koppor]

With -jr-theme, memories of the C64 come back. I "strictly" used -jr-theme color 😇

[koppor]

I added src/test/resources/testbib/simple-search-library.bib to be able to display all 4 cases on a single page.

• Search for S
• Selectd group g

Then, Sg matches both, S only the search string, g only group, and n` none of them.

[LoayGhreeb]

Double-clicking on an even row removes the selection color.

---

Edit: If there is no active search query and the 'All Entries' group is selected, the odd rows keeps the selection color. However, if there is an active search or a selected group, all rows will lose the selection color when double-clicked.

[LoayGhreeb]

The text is not shown on the selected non-matched entry.

[koppor]

However, if there is an active search or a selected group, all rows will lose the selection color when double-clicked.

Single click works. What magic does JabRef do on a double click?

[LoayGhreeb]

The only action on double-click is to open the entry editor:

jabref/src/main/java/org/jabref/gui/maintable/MainTable.java

Lines 142 to 146 in db9f83c

	.withOnMouseClickedEvent((entry, event) -> {
	if (event.getClickCount() == 2) {
	libraryTab.showAndEdit(entry.getEntry());
	}
	})

[koppor]

If we cannot fix the next 20 hours, we merge and create two follow-up issues. - Without stripes, it looks really bad IMHO.

[LoayGhreeb]

Sorry for the confusion in #11579 (comment), but the issue only affects the even rows. Odd rows keep the selection color in all cases.

[koppor]

I cannot manage to "double filter":

.table-row-cell:not(.focused):matching-groups-not-search > .table-cell {
    -fx-text-fill: -jr-match-3-text-color;
}

That would be requried to have the text color only applied when not focused - but does not trigger at all.

Seems to be known issue - https://stackoverflow.com/q/39355081/873282

Thus, added a work around at e7c0460 (#11579).

[koppor]

The mentioned issues should be fixed now.

[github-actions]

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

[koppor]

Other color scheme PR: #3839