Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency @cloudflare/vitest-pool-workers to ^0.8.0 #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency @cloudflare/vitest-pool-workers to ^0.8.0 #152

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 10, 2025 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@cloudflare/vitest-pool-workers (source) ^0.5.36 -> ^0.8.0 age adoption passing confidence

Release Notes

cloudflare/workers-sdk (@​cloudflare/vitest-pool-workers)

v0.8.0

Compare Source

Minor Changes

  • #​7334 869ec7b Thanks @​threepointone! - chore: update esbuild

    This patch updates esbuild from 0.17.19 to 0.24.2. That's a big bump! Lots has gone into esbuild since May '23. All the details are available at https://github.com/evanw/esbuild/blob/main/CHANGELOG.md / https://github.com/evanw/esbuild/blob/main/CHANGELOG-2023.md.

    • We now support all modern JavasScript/TypeScript features suported by esbuild (as of December 2024). New additions include standard decorators, auto-accessors, and the using syntax.

    • 0.18 introduced wider support for configuration specified via tsconfig.json https://github.com/evanw/esbuild/issues/3019. After observing the (lack of) any actual broken code over the last year for this release, we feel comfortable releasing this without considering it a breaking change.

    • 0.19.3 introduced support for import attributes

      import stuff from './stuff.json' with { type: 'json' }

      While we don't currently expose the esbuild configuration for developers to add their own plugins to customise how modules with import attributes are bundled, we may introduce new "types" ourselves in the future.

    • 0.19.0 introduced support for wildcard imports. Specifics here (https://github.com/evanw/esbuild/blob/main/CHANGELOG-2023.md#0190). tl;dr -

      • These 2 patterns will bundle all files that match the glob pattern into a single file.

        const json1 = await import("./data/" + kind + ".json");
        const json2 = await import(`./data/${kind}.json`);

      • This pattern will NOT bundle any matching patterns:

        const path = "./data/" + kind + ".js";
const json2 = await import(path);

        You can use find_additional_modules to bundle any additional modules that are not referenced in the code but are required by the project.

      Now, this MAY be a breaking change for some. Specifically, if you were previously using the pattern (that will now include all files matching the glob pattern in the bundle), BUT find_additional_modules was NOT configured to include some files, those files would now be included in the bundle. For example, consider this code:

      // src/index.js
export default {
	async fetch() {
		const url = new URL(request.url);
		const name = url.pathname;
		const value = (await import("." + name)).default;
		return new Response(value);
	},
};

      Imagine if in that folder, you had these 3 files:

      // src/one.js
export default "one";
      // src/two.js
export default "two";
      // src/hidden/secret.js
export default "do not share this secret";

      And your wrangler.toml was:

      name = "my-worker"
main = "src/index.js

      Before this update:

      1. A request to anything but http://localhost:8787/ would error. For example, a request to http://localhost:8787/one.js would error with No such module "one.js".
      2. Let's configure wrangler.toml to include all .js files in the src folder:
      name = "my-worker"
main = "src/index.js

find_additional_modules = true
rules = [
  { type = "ESModule", globs = ["*.js"]}
]

      Now, a request to http://localhost:8787/one.js would return the contents of src/one.js, but a request to http://localhost:8787/hidden/secret.js would error with No such module "hidden/secret.js". To include this file, you could expand the rules array to be:

      rules = [
  { type = "ESModule", globs = ["**/*.js"]}
]

      Then, a request to http://localhost:8787/hidden/secret.js will return the contents of src/hidden/secret.js.

      After this update:

      • Let's put the wrangler.toml back to its original configuration:
      name = "my-worker"
main = "src/index.js

      • Now, a request to http://localhost:8787/one.js will return the contents of src/one.js, but a request to http://localhost:8787/hidden/secret.js will ALSO return the contents of src/hidden/secret.js. THIS MAY NOT BE WHAT YOU WANT. You can "fix" this in 2 ways:

        1. Remove the inline wildcard import:
        // src/index.js
export default {
	async fetch() {
		const name = new URL(request.url).pathname;
		const moduleName = "./" + name;
		const value = (await import(moduleName)).default;
		return new Response(value);
	},
};

        Now, no extra modules are included in the bundle, and a request to http://localhost:8787/hidden/secret.js will throw an error. You can use the find_additional_modules feature to include it again.

        1. Don't use the wildcard import pattern:
        // src/index.js
import one from "./one.js";
import two from "./two.js";

export default {
	async fetch() {
		const name = new URL(request.url).pathname;
		switch (name) {
			case "/one.js":
				return new Response(one);
			case "/two.js":
				return new Response(two);
			default:
				return new Response("Not found", { status: 404 });
		}
	},
};

        Further, there may be some files that aren't modules (js/ts/wasm/text/binary/etc) that are in the folder being included (For example, a photo.jpg file). This pattern will now attempt to include them in the bundle, and throw an error. It will look like this:

        [ERROR] No loader is configured for ".png" files: src/photo.jpg

        To fix this, simply move the offending file to a different folder.

        In general, we DO NOT recommend using the wildcard import pattern. If done wrong, it can leak files into your bundle that you don't want, or make your worker slightly slower to start. If you must use it (either with a wildcard import pattern or with find_additional_modules) you must be diligent to check that your worker is working as expected and that you are not leaking files into your bundle that you don't want. You can configure eslint to disallow dynamic imports like this:

        // eslint.config.js
export default [
	{
		rules: {
			"no-restricted-syntax": [
				"error",
				{
					selector: "ImportExpression[argument.type!='Literal']",
					message:
						"Dynamic imports with non-literal arguments are not allowed.",
				},
			],
		},
	},
];
Patch Changes

v0.7.8

Compare Source

Patch Changes

v0.7.7

Compare Source

Patch Changes

v0.7.6

Compare Source

Patch Changes

  • #​8338 2d40989 Thanks @​GregBrimble! - feat: Upload _headers and _redirects if present with Workers Assets as part of wrangler deploy and wrangler versions upload.

  • #​8288 cf14e17 Thanks @​CarmenPopoviciu! - feat: Add assets Proxy Worker skeleton in miniflare

    This commit implements a very basic Proxy Worker skeleton, and wires it in the "pipeline" miniflare creates for assets. This Worker will be incrementally worked on, but for now, the current implementation will forward all incoming requests to the Router Worker, thus leaving the current assets behaviour in local dev, the same.

    This is an experimental feature available under the --x-assets-rpc flag: wrangler dev --x-assets-rpc.

  • Updated dependencies [2d40989, da568e5, cf14e17, af9a57a, fbba583, bca1fb5, 79c7810]:

v0.7.5

Compare Source

Patch Changes

v0.7.4

Compare Source

Patch Changes

v0.7.3

Compare Source

Patch Changes

v0.7.2

Compare Source

Patch Changes

v0.7.1

Compare Source

Patch Changes

v0.7.0

Compare Source

Minor Changes
  • #​7923 aaa9cca Thanks @​penalosa! - Support Vitest v3. While this drops testing for Vitest v2, we expect Vitest v2 will continue to work as well.
Patch Changes

v0.6.16

Compare Source

Patch Changes

v0.6.15

Compare Source

Patch Changes

v0.6.14

Compare Source

Patch Changes

v0.6.13

Compare Source

Patch Changes

v0.6.12

Compare Source

Patch Changes

v0.6.11

Compare Source

Patch Changes

v0.6.10

Compare Source

Patch Changes

v0.6.9

Compare Source

Patch Changes

v0.6.8

Compare Source

Patch Changes

v0.6.7

Compare Source

Patch Changes

v0.6.6

Compare Source

Patch Changes

v0.6.5

Compare Source

Patch Changes

v0.6.4

Compare Source

Patch Changes

v0.6.3

Compare Source

Patch Changes

v0.6.2

Compare Source

Patch Changes

v0.6.1

Compare Source

Patch Changes

v0.6.0

Compare Source

Minor Changes
Patch Changes

v0.5.41

Compare Source

Patch Changes

v0.5.40

Compare Source

Patch Changes

v0.5.39

Compare Source

Patch Changes

v0.5.38

Compare Source

Patch Changes

v0.5.37

Compare Source

Patch Changes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 084cf88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot changed the title chore(deps): update dependency @cloudflare/vitest-pool-workers to ^0.6.0 chore(deps): update dependency @cloudflare/vitest-pool-workers to ^0.7.0 Feb 18, 2025
@renovate renovate bot force-pushed the renovate/cloudflare-vitest-pool-workers-0.x branch from 96b9392 to 042acc0 Compare February 18, 2025 20:24
@renovate renovate bot force-pushed the renovate/cloudflare-vitest-pool-workers-0.x branch from 042acc0 to 084cf88 Compare March 13, 2025 13:08
@renovate renovate bot changed the title chore(deps): update dependency @cloudflare/vitest-pool-workers to ^0.7.0 chore(deps): update dependency @cloudflare/vitest-pool-workers to ^0.8.0 Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants