fix(templates): moving the error handling for no changes to the correct place #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pull request includes a refactor of the
Patchmethod in thetemplates/_update.tmplfile to improve error handling and code readability. The most important changes involve reordering the SQL generation and error handling logic.Improvements to error handling and code readability:
res.GenerateSQL()) has been moved to occur after the initial error check forpatcher.NewDiffSQLPatch, ensuring that the SQL generation is only attempted if the initial patch creation is successful.GenerateSQLmethod, simplifying the error message to "failed to generate patch" in both cases.