(#196) fix: Use IANA-recommended port range and add retry on RuntimeError #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| debugpy.listen(("localhost", port)) | ||
| break | ||
| except OSError: | ||
| except (OSError, RuntimeError): |
Collaborator
There was a problem hiding this comment.
why the RuntimeError error in this PR?
Author
There was a problem hiding this comment.
According to the traceback in the linked issue, a RuntimeError is raised when the specific port is unavailable, so I've updated the code to catch it.
However, I am concerned that RuntimeError is too generic. Catching it might trigger the retry loop for errors unrelated to the port issue. To mitigate this, I suggest adding a maximum retry limit. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#196
Description
I updated the implementation to use the port range recommended by IANA, and also added a retry mechanism for cases where a RuntimeError occurs.
https://www.rfc-editor.org/rfc/rfc6335