misc: Fix useless use of cat and typo

Signed-off-by: GwanYeong Kim <[email protected]>
JangSoJin · Sep 7, 2018 · 1712de4 · 1712de4
1 parent e16e5a9
commit 1712de4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/misc/bash-completion.sh b/misc/bash-completion.sh
@@ -1,5 +1,5 @@
 _uftrace () {
-    local cur prev subcmd options uftrace_comp
+    local cur prev subcmds options uftrace_comp
 
     cur=${COMP_WORDS[COMP_CWORD]}
     prev=${COMP_WORDS[COMP_CWORD - 1]}

diff --git a/misc/install-elfutils.sh b/misc/install-elfutils.sh
@@ -6,7 +6,7 @@ prefix=/usr/local
 objdir=$(readlink -f ${objdir:-${PWD}})
 builddir=${objdir}/.build
 
-n_cpus=$(cat /proc/cpuinfo | grep ^processor | wc -l)
+n_cpus=$(grep -c ^processor /proc/cpuinfo)
 
 usage() {
     echo "Usage: $0 [<options>]

diff --git a/misc/version.sh b/misc/version.sh
@@ -14,12 +14,12 @@ GIT_VERSION=
 SRCDIR=$3
 
 if test -f ${VERSION_FILE}; then
-    FILE_VERSION=$(cat ${VERSION_FILE} 2>/dev/null | cut -d'"' -f2)
+    FILE_VERSION=$(cut -d'"' -f2 ${VERSION_FILE})
 fi
 
-if test -d .git -a -n "`git --version 2>/dev/null`"; then
+if test -d .git -a -n "$(git --version 2>/dev/null)"; then
     # update current version using git tags
-    GIT_VERSION=`git describe --tags --abbrev=4 --match="v[0-9].[0-9]*" 2>/dev/null`
+    GIT_VERSION=$(git describe --tags --abbrev=4 --match="v[0-9].[0-9]*" 2>/dev/null)
     CURR_VERSION=${GIT_VERSION}
 fi