Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate margin of error for decompose_depolarizer with jax #25

Closed
kenjim21 opened this issue Aug 16, 2024 · 2 comments · Fixed by #29
Closed

Investigate margin of error for decompose_depolarizer with jax #25

kenjim21 opened this issue Aug 16, 2024 · 2 comments · Fixed by #29
Labels
bug Something isn't working

Comments

@kenjim21
Copy link
Collaborator

kenjim21 commented Aug 16, 2024 •
edited
Loading

Screenshot 2024-08-16 180213

This is the margin of difference between the matrices when I print them
@kenjim21
Copy link
Collaborator Author

Appears that each non-zero final result is off at the 6th decimal compared to the zeroes

@Jashcraf
Copy link
Owner

For reference my Jax machine precision is ~1e-16, so it’s probably real

>>> import jax.numpy as np
>>> np.finfo(float).eps
np.float64(2.220446049250313e-16)

@kenjim21 kenjim21 added the bug Something isn't working label Oct 11, 2024
@kenjim21 kenjim21 linked a pull request Oct 12, 2024 that will close this issue
25 investigate margin of error for decompose depolarizer with jax #29
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

25 investigate margin of error for decompose depolarizer with jax Jashcraf/katsu
2 participants
@Jashcraf @kenjim21