25 investigate margin of error for decompose depolarizer with jax #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
am a little confused on error as while I am using a venv with python 11, still confused on why there's the given error. will look into |
…r-with-jax' of https://github.com/Jashcraf/katsu into 25-investigate-margin-of-error-for-decompose_depolarizer-with-jax
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 72.64% 72.64%
=======================================
Files 3 3
Lines 318 318
=======================================
Hits 231 231
Misses 87 87 ☔ View full report in Codecov by Sentry. |
|
shall I merge and close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated default dtype for Jax from float32 to float64 to fix precision errors. Also corrected Kenji's last name in paper