Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25 investigate margin of error for decompose depolarizer with jax #29

Merged
merged 10 commits into from
Oct 22, 2024
Merged

25 investigate margin of error for decompose depolarizer with jax #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6881a34
fixing name (may just be pushed separately)
kenjim21 Aug 30, 2024
0e0215b
starting notebook for comparing performance. name and location tbd
kenjim21 Aug 30, 2024
f1e36cc
Updating to current search target for error
kenjim21 Sep 13, 2024
165bfb0
changed default for float32 to float64 with jax
kenjim21 Oct 11, 2024
06676bd
removing unneeded notebook
kenjim21 Oct 12, 2024
c01c9c1
trying different numpy version for tests
kenjim21 Oct 21, 2024
4bcdb65
Merge branch '25-investigate-margin-of-error-for-decompose_depolarize…
kenjim21 Oct 21, 2024
30ddab8
undoing version requirement change numpy
kenjim21 Oct 21, 2024
2daa6bc
updated power
kenjim21 Oct 21, 2024
e4f411f
Merge branch 'main' into 25-investigate-margin-of-error-for-decompose…
kenjim21 Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions katsu/katsu_math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ def set_backend_to_cupy():

def set_backend_to_jax():
"""Convenience method to automatically configure katsu's backend to jax."""
import jax.numpy as jnp
import jax as jax

np._srcmodule = jnp
jax.config.update("jax_enable_x64", True)
np._srcmodule = jax.numpy

return

Expand Down
4 changes: 2 additions & 2 deletions katsu/mueller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ def decompose_retarder(M, return_all=False, normalize=False):
Whether to return the retarder and diattenuator vs just the retarder.
Defaults to False, which returns both

Returns
Returns
-------
numpy.ndarray
Retarder component of mueller matrix
Expand All @@ -625,7 +625,7 @@ def decompose_retarder(M, return_all=False, normalize=False):
Mr = M @ np.linalg.inv(Md)

if normalize:
Mr = Mr/np.max(np.abs(Mr))
Mr = Mr/np.max(np.abs(Mr))
else:
Mr = Mr

Expand Down
2 changes: 1 addition & 1 deletion paper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ authors:
- name: Manxuan Zhang
orcid: 0000-0003-3567-6839
affiliation: 3
- name: Kenji Mulhal
- name: Kenji Mulhall
affiliation: 4
- name: Ramya M. Anche
orcid: 0000-0002-4989-6253
Expand Down
Loading