[broker-67] Design of authentication mechanism #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazyrokr
changed the title
# Conflicts: # acl-groovy-dsl/src/main/groovy/javasabr/mqtt/service/acl/AclRulesLoader.groovy # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java
Test Coverage Report
|
JavaSaBr
reviewed
Dec 13, 2025
|
|
||
| @Bean | ||
| AuthenticationService authenticationService( | ||
| List<AuthenticationProvider> credentialSource, |
Owner
There was a problem hiding this comment.
authenticationProviders or credentialSource?
| @@ -0,0 +1,5 @@ | |||
| DROP TABLE IF EXISTS user_credentials; | |||
| CREATE TABLE user_credentials ( | |||
Owner
There was a problem hiding this comment.
I think for our own version of DB tables we should use Flyway
Collaborator
Author
There was a problem hiding this comment.
Sure, let's implement this within the ticket #141
| @@ -0,0 +1,12 @@ | |||
| package javasabr.mqtt.model.message; | |||
|
|
|||
| public interface AuthRequest { | |||
Owner
There was a problem hiding this comment.
I think it can be a record. it's not a very intensive operation, we can make it "nicer"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#67
The main goal of the PR is to prepare a module and class structures covering the most common authentication mechanisms, so it introduces the following entities: