#69 Improve publish delivering to subscribers part 5 #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…livering-to-subscribers
…-publish-delivering-to-subscribers-part-2
…livering-to-subscribers-part-2 # Conflicts: # core-service/src/main/java/javasabr/mqtt/service/publish/handler/impl/Qos1MqttPublishOutMessageHandler.java # core-service/src/main/java/javasabr/mqtt/service/publish/handler/impl/Qos2MqttPublishOutMessageHandler.java # core-service/src/main/java/javasabr/mqtt/service/publish/handler/impl/TrackableMqttPublishOutMessageHandler.java # core-service/src/main/java/javasabr/mqtt/service/session/impl/InMemoryProcessingPublishes.java
…improve-publish-delivering-to-subscribers-part-3
…livering-to-subscribers-part-3 # Conflicts: # network/src/main/java/javasabr/mqtt/network/message/out/PublishReleaseMqtt311OutMessage.java
…improve-publish-delivering-to-subscribers-part-4
…livering-to-subscribers-part-4
…improve-publish-delivering-to-subscribers-part-5
…nt-flow-control-part-5 # Conflicts: # core-service/src/main/java/javasabr/mqtt/service/message/handler/impl/PublishMqttInMessageHandler.java
Test Coverage Report
|
…nt-flow-control-part-5
…nt-flow-control-part-5
crazyrokr
requested changes
Dec 12, 2025
| return true; | ||
| } else if (!(message instanceof PublishReleaseMqttInMessage release)) { | ||
| log.warning(networkUser.clientId(), message, "[%s] Not expected message:[%s]"::formatted); | ||
| log.warning(clientId, message.messageType(), "[%s] Not expected message:[%s]"::formatted); |
Collaborator
There was a problem hiding this comment.
Could we consider renaming messageType() -> type()?
Collaborator
There was a problem hiding this comment.
Okay, but message.messageType() doesn't look nice
| publishOutHandler.handle(testPublish, subscriber) | ||
| then: | ||
| result == PublishHandlingResult.SUCCESS | ||
| def publish = user.nextSentMessage(PublishMqtt5OutMessage) |
Collaborator
There was a problem hiding this comment.
It looks like this variable should be renamed from publish to message or even actualSentMessage to avoid confusion with instances of Publish.
Owner
Author
There was a problem hiding this comment.
@crazyrokr, and what are the names for publish received, publish released and publish ack messages then?
Collaborator
There was a problem hiding this comment.
publishMessage, publishAckMessage, etc.
| publishOutHandler.handle(testPublish, subscriber) | ||
| then: | ||
| result == PublishHandlingResult.SUCCESS | ||
| def publish = user.nextSentMessage(PublishMqtt5OutMessage) |
Collaborator
There was a problem hiding this comment.
The same as the previous comment. Please check all tests below.
crazyrokr
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#69
Description