-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix event handling with react-beautiful-dnd #5842
Open
itsdouges
wants to merge
7
commits into
JedWatson:master
Choose a base branch
from
itsdouges:fix-event-handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
264109d
chore: add test cases
itsdouges df2d44c
fix: fixes control bailing out of an event if it has had prevent defa…
itsdouges 5e04ec6
chore: add tests covering alternative event flows
itsdouges 67e005f
chore: add changeset
itsdouges 649eec7
chore: fix lock
itsdouges d3fd7f7
chore: nit
itsdouges 16b4be7
chore: fix tests
itsdouges File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'react-select': patch | ||
| --- | ||
|
|
||
| Select no longer stops the control mouse down event from firing if someone listening to the event calls `.preventDefault()`. This resolves issues seen with react-select interop-ing with other libraries, such as react-beautiful-dnd. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import selector from '../fixtures/selectors.json'; | ||
| import cypressJson from '../../cypress.json'; | ||
|
|
||
| describe('event propagation', () => { | ||
| before(() => { | ||
| cy.visit(cypressJson.baseUrl); | ||
| cy.title().should('equal', 'React-Select'); | ||
| cy.get('h1').should('contain', 'Test Page for Cypress'); | ||
| }); | ||
|
|
||
| beforeEach(() => { | ||
| cy.reload(); | ||
| }); | ||
|
|
||
| it('should open select via value container after a parent prevent defaulted the event', () => { | ||
| cy.get(selector.preventDefaultTest.valueContainer) | ||
| .click() | ||
| .get(selector.preventDefaultTest.menu) | ||
| .should('exist'); | ||
| }); | ||
|
|
||
| it('should open select via indicator after a parent prevent defaulted the event', () => { | ||
| cy.get(selector.preventDefaultTest.indicator) | ||
| .click() | ||
| .get(selector.preventDefaultTest.menu) | ||
| .should('exist'); | ||
| }); | ||
|
|
||
| it('should close react calendar when interacting with the select indicator', () => { | ||
| cy.get(selector.bubblingTest.datePickerInput) | ||
| .click() | ||
| .get(selector.bubblingTest.indicator) | ||
| .click() | ||
| .get(selector.bubblingTest.menu) | ||
| .should('exist') | ||
| .get(selector.bubblingTest.datePickerMenu) | ||
| .should('not.exist'); | ||
| }); | ||
|
|
||
| it('should close react calendar when interacting with the select value container', () => { | ||
| cy.get(selector.bubblingTest.datePickerInput) | ||
| .click() | ||
| .get(selector.bubblingTest.valueContainer) | ||
| .click() | ||
| .get(selector.bubblingTest.menu) | ||
| .should('exist') | ||
| .get(selector.bubblingTest.datePickerMenu) | ||
| .should('not.exist'); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a test for this particular use case - dropdown indicator preventing default event (
react-select/packages/react-select/src/Select.tsx
Line 1345 in 06e3488
Also, not quite clear why
stopPropagationis not a case,onMenuMouseDownuses it (uses both) for example.This code was added here for a reason, and I can see other pieces relying on this one. Basically - all
.preventDefaultin this file.What if we try to change the game rules and just rely on a different information source?
Might be a little too much code to support a single line, but this code will keep the old behavior and unlock our usecase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prevent default was added in #5134 — I can't imagine anything in Select is leaning on it?
We can definitely change the rules like you said if the behaviour is needed. I'm just not sure it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing tests might point to it being needed I suppose ;).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, and you added tests for #5050 case, and they are passing. May be something else in between, including changes in DatePicker resolved the problem in the meanwhile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you're right, which is what the tests are showing now. I'll dig in soon.