-
Couldn't load subscription status.
- Fork 65
androidtv 12 & 13 #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
androidtv 12 & 13 #340
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
daddefd
add support for androidtv 12 & 13
Nortonko 7e569ed
reformated code by black formater
Nortonko 7f68b69
reformatted code by black again
Nortonko 556af13
fixed missing CMD_CURRENT_APP_MEDIA_SESSION_STATE12
Nortonko 4a7bd04
tried to fix the tests errors
Nortonko ae0f179
fix missing CMD_VOLUME_SET_COMMAND11
Nortonko c31e663
fixed errors
Nortonko 9368457
Stmts Miss
Nortonko 48c3948
fix
Nortonko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -830,7 +830,7 @@ async def set_volume_level(self, volume_level): | |
|
|
||
| new_volume = int(min(max(round(self.max_volume * volume_level), 0.0), self.max_volume)) | ||
|
|
||
| await self._adb.shell("media volume --show --stream 3 --set {}".format(new_volume)) | ||
| await self._adb.shell(self._cmd_volume_set().format(new_volume)) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change needs to be made in |
||
|
|
||
| # return the new volume level | ||
| return new_volume / self.max_volume | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be simpler to take
volume_levelas a parameter and return the formatted string.