Move more extensions to new extension format#94
Merged
JeremyKuhne merged 1 commit intomainfrom Dec 7, 2025
Merged
Conversation
Also add workaround in TypeExtensionTests for spurious CS8620 warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add workaround in TypeExtensionTests for spurious CS8620 warning
Note
Migrates extension methods to the new scoped
extension(...)syntax across multiple areas, removes an unused span split helper, and adds null-forgiving operators in tests to silence CS8620 warnings.extension(...)syntax):System/Globalization/InternalDateTimeExtensions.cs: WrapGetDate,GetTime,GetTimePreciseunderextension(ref readonly DateTime); makeInternalDateTimeprivate.Touki/Io/StreamExtensions.cs(both Framework and library): GroupStream,StreamWriter, andTextWriterhelpers into respectiveextension(...)blocks; keep read/write and formatted write APIs.Touki/TypeExtensions.cs: MoveIsAssignableTointoextension(Type?).Touki/Buffers/SpanExtensions.cs: MoveSliceAtNullandCompareOrdinalAsStringintoextension(...)blocks; removeSplitToEnumerable.Touki/Buffers/SpanReaderExtensions.cs: MoveTryReadPositiveIntegerintoextension(ref SpanReader<char>).Touki/EnumExtensions.cs: Group flag helpers intoextension<T>(T)andextension<T>(ref T)blocks (query and mutating operations).Touki/Text/StringBuilderExtensions.cs: Group append/format helpers intoextension(StringBuilder).TestSupport/TypeExtensionTests.cs: Add null-forgiving (!) ontypeof(...)args to work around CS8620 analyzer noise; no behavior changes.Written by Cursor Bugbot for commit 23f0e7a. This will update automatically on new commits. Configure here.