Rotary scroll input for skiko #2133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
May 26, 2025
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/CanvasLayersComposeScene.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/ComposeScene.skiko.kt
Show resolved
Hide resolved
MatkovIvan
approved these changes
May 26, 2025
igordmn
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new function
ComposeScene.sendRotaryScrollEventallows sending rotary events to compose. I need this functionality for my Linux smart watch app. With this new function it is possible to forward rotary events from the system to compose code.Compose code can listen to these rotary events using already existing
Modifier.onRotaryScrollEvent. See added test for details. This is already used throughout the Wear Compose libraries for example.What do you think of this?
Testing
RenderPhasesTest.rotaryEventsProcessesScheduledCoroutinesRelease Notes
N/A