Skip to content

Rotary scroll input for skiko #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2025
Merged

Conversation

Thomas-Vos
Copy link

The new function ComposeScene.sendRotaryScrollEvent allows sending rotary events to compose. I need this functionality for my Linux smart watch app. With this new function it is possible to forward rotary events from the system to compose code.

Compose code can listen to these rotary events using already existing Modifier.onRotaryScrollEvent. See added test for details. This is already used throughout the Wear Compose libraries for example.

What do you think of this?

Testing

  • RenderPhasesTest.rotaryEventsProcessesScheduledCoroutines
  • Also tested on physical device using my multiplatform fork of Wear Compose libraries

Release Notes

N/A

Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this addition fits properly to ComposeScene APIs 👍

@MatkovIvan MatkovIvan requested a review from igordmn May 26, 2025 08:34
@igordmn igordmn merged commit f81a2e2 into JetBrains:jb-main May 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants