Implement enter end exit animation for Dialog #2596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASalavei
changed the title
MatkovIvan
reviewed
Nov 26, 2025
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
reviewed
Nov 26, 2025
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt
Outdated
Show resolved
Hide resolved
ASalavei
added a commit
that referenced
this pull request
Dec 4, 2025
Required due to the introduction of a new API (#2596) that needs to be consumed in material3 ## Release Notes N/A
# Conflicts: # compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt
MatkovIvan
reviewed
Dec 4, 2025
Member
MatkovIvan
left a comment
MatkovIvan
left a comment
There was a problem hiding this comment.
LGTM in general, just a few minor things
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt
Outdated
Show resolved
Hide resolved
m-sasha
reviewed
Dec 4, 2025
m-sasha
left a comment
m-sasha
left a comment
There was a problem hiding this comment.
Can we add a test that validates the crash we had with the previous solution (due to reparenting the content) doesn't happen?
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/animation/Animation.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt
Outdated
Show resolved
Hide resolved
Author
Done |
MatkovIvan
approved these changes
Dec 4, 2025
Member
MatkovIvan
left a comment
MatkovIvan
left a comment
There was a problem hiding this comment.
LGTM, just styling nitpicks
PS can't wait for adoption of automated formatter check
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/animation/Animation.skiko.kt
Show resolved
Hide resolved
...erial3/material3/src/skikoMain/kotlin/androidx/compose/material3/WideNavigationRail.skiko.kt
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
animateTransitionparameter to theDialogPropertiesFixes https://youtrack.jetbrains.com/issue/CMP-4365/iOS-iOS-Dialog-has-no-enter-and-exit-animation
Animation
iOS:
Simulator.Screen.Recording.-.iPhone.16.-.2025-10-23.at.16.01.19.mp4
Desktop:
Screen.Recording.2025-10-23.at.15.50.47.mov
Comparing with Android:
Screen.Recording.2025-09-01.at.16.03.32.mov
Release Notes
Features - Multiple Platforms
Dialog. It might have disabled viaDialogProperties.animateTransitionor via global feature flagComposeUiFlags.isDialogAnimationEnabled