Do not expose skiko library #689
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
approved these changes
Jul 18, 2023
| @@ -117,7 +117,7 @@ if (AndroidXComposePlugin.isMultiplatformEnabled(project)) { | |||
| skikoMain { | |||
| dependsOn(commonMain) | |||
| dependencies { | |||
| api(libs.skikoCommon) | |||
| implementation(libs.skikoCommon) | |||
There was a problem hiding this comment.
Yep. We need to revisit our API because there are a few skiko types "leaks" into public
igordmn
reviewed
Jul 18, 2023
| @@ -94,7 +94,7 @@ if(AndroidXComposePlugin.isMultiplatformEnabled(project)) { | |||
| skikoMain { | |||
| dependsOn(commonMain) | |||
| dependencies { | |||
| api(libs.skikoCommon) | |||
| implementation(libs.skikoCommon) | |||
There was a problem hiding this comment.
Could you also add a section API Change to the message? The plan is to make a link to this PR in the CHANGELOG.
P.S. Probably will be better to do that in the DSL PR in compose-multiplatform repo
There was a problem hiding this comment.
MatkovIvan
force-pushed
the
ivan.matkov/do-not-expose-skiko
branch
from
8236565 to
22fe418
Compare
MatkovIvan
pushed a commit
that referenced
this pull request
Sep 10, 2024
set-output is now deprecated. See: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Test: GH Workflows This is an imported pull request from androidx#689. Resolves #689 Github-Pr-Head-Sha: 13e0e20 GitOrigin-RevId: a020a5f Change-Id: Iba9cfd114e922a52ca737345a072f8309275430c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Skiko library is currently included as
apithat makes possible using this unstable API without explicit adding the library.It's even used in the official samples that might lead to widespread usage of it.
Since it's an implementation details, it should not be exposed by default. In the same time we need to allow users use it "as is" by adding skiko as explicit dependency to their project.
API Change
Skiko library is not exported as the library API anymore. If you need to use
org.jetbrains.skiko.*ororg.jetbrains.skia.*, please include this library directly into the project.Compose plugin contains DSL to avoid version conflicts
Issues Fixed
Fixes JetBrains/compose-multiplatform#3152