fix(prompt): Fix reasoning for openai and google clients#1868
Open
tiginamaria wants to merge 2 commits intodevelopfrom
Open
fix(prompt): Fix reasoning for openai and google clients#1868tiginamaria wants to merge 2 commits intodevelopfrom
tiginamaria wants to merge 2 commits intodevelopfrom
Conversation
antoniibelyshev
approved these changes
Apr 21, 2026
Collaborator
antoniibelyshev
left a comment
antoniibelyshev
left a comment
There was a problem hiding this comment.
Thank you, the fix looks good! Can we also add a test for the reasoning?
Contributor
|
I'll add the tests in a bit UPD: done |
aozherelyeva
force-pushed
the
tigina/reasoning-fix
branch
from
b27c7af to
be06178
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1865 #1866