Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove animations when it's disabled in system settings #222

Merged
merged 5 commits into from
Mar 14, 2025

Conversation

stevenxxiu
Copy link

Closes #185.

@stevenxxiu stevenxxiu force-pushed the feat/remove-animation branch 2 times, most recently from 825b1be to 7dda6e1 Compare March 9, 2025 14:32
@stevenxxiu stevenxxiu force-pushed the feat/remove-animation branch from 7dda6e1 to 4e6bc6d Compare March 11, 2025 08:42
@stevenxxiu stevenxxiu force-pushed the feat/remove-animation branch from 4e6bc6d to f5a5cff Compare March 11, 2025 09:26
To navigate without animations, the value for arguments of type @AnimatorRes should be -1.
@JingMatrix
Copy link
Owner

JingMatrix commented Mar 13, 2025

If possible, please consider hiding the component CircularProgressIndicator SwipeRefreshLayout.
It is inconsistent to have a progress indicator with other animations disabled.

@stevenxxiu
Copy link
Author

If possible, please consider hiding the component CircularProgressIndicator SwipeRefreshLayout. It is inconsistent to have a progress indicator with other animations disabled.

If SwipeRefreshLayout is removed, then is there a way to tell when the refresh finishes? Otherwise it could be something that's informative. I don't mind spinner loading animations for that reason.

@JingMatrix
Copy link
Owner

Okay for that.

I wonder if if the smoothScroll parameter of TabLayoutMediator really creates animations.
I cannot tell the difference from my device.

@stevenxxiu
Copy link
Author

stevenxxiu commented Mar 13, 2025

I wonder if if the smoothScroll parameter of TabLayoutMediator really creates animations. I cannot tell the difference from my device.

It should remove the sliding animation that shows up when you switch tabs in the Logs panel or in a Repository panel's module.

I tried this in an emulator before, and following your comments tried it on my real phone. It works there too.

Are you sure you disabled all animations in system settings? "Animation duration scale", "Window animation scale", "Transition animation scale".

@JingMatrix JingMatrix merged commit 90d3712 into JingMatrix:master Mar 14, 2025
1 check passed
@stevenxxiu stevenxxiu deleted the feat/remove-animation branch March 14, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow system wide animation settings
2 participants