Bugfix/fix GitHub actions#151
Merged
JohanSjoblom merged 5 commits intomasterfrom Nov 20, 2025
Merged
Conversation
… fix missing glib.h when building bluepy
Collaborator
Author
|
To run the tests locally in my dev environment, I used the following commands:
|
Owner
|
Nice work. Fixing the unit tests was on my todo list, so greatly appreciated. I have no strong opinion on naming branches. If they come from issues I usually keep the issue number there, if they are fixes I think all hotfix/x or fix/x or bugfix/x like you did is more than fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the continuous integration workflow (github action). I re-enabled the workflow for one run. You can see the results here: https://github.com/JohanSjoblom/picochess/actions/runs/19533218530
The main change is the Python version used for the actions and I changed the Ubuntu version to a specific, slightly older version to fix the bluepy compile issue.
All the failing tests are fixed and some of the lint and type errors as well.
There are still some warnings/errors left but the actions are running again.
Let me know if you would like me to create an issue first and rename the branch or how to go about naming branches in the future.