Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more constructors for SpatialQueryFilter #312

Closed
wants to merge 1 commit into from

Conversation

Jondolf
Copy link
Owner

@Jondolf Jondolf commented Jan 24, 2024

Objective

SpatialQueryFilter::new is the same as SpatialQueryFilter::default, and constructing the filters can be a bit verbose. There should be more and better constructors.

Solution

Change SpatialQueryFilter::new to take the masks and excluded entities, and add the from_mask_bits, from_masks, and from_excluded_entities constructors.


Migration Guide

Change SpatialQueryFilter::new() to SpatialQueryFilter::default() or use the new constructors instead.

@Jondolf Jondolf added C-Enhancement New feature or request A-Spatial-Query Relates to spatial queries, such as ray casting, shape casting, and intersection tests labels Jan 24, 2024
@Jondolf
Copy link
Owner Author

Jondolf commented Jan 24, 2024

Closing in favor of #313.

@Jondolf Jondolf closed this Jan 24, 2024
@Jondolf Jondolf deleted the query-filter-constructors branch January 24, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spatial-Query Relates to spatial queries, such as ray casting, shape casting, and intersection tests C-Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant