Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SleepingPlugin not being optional and add WakeUpBody command #624

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Fix SleepingPlugin not being optional and add WakeUpBody command #624

merged 1 commit into from
Jan 11, 2025

Conversation

Jondolf
Copy link
Owner

@Jondolf Jondolf commented Jan 11, 2025

Objective

Avian 0.2.0 has a regression from 0.1 where the TimeSleeping component is required, but it is only added automatically (as a required component) if the SleepingPlugin is enabled. This means that disabling the SleepingPlugin breaks physics.

Solution

Make TimeSleeping properly optional for rigid bodies.

I also added a WakeUpBody Command to clean up some logic and abstract away resetting TimeSleeping.

@Jondolf Jondolf added C-Regression Behaviour that was working before is now worse or broken A-Dynamics Relates to rigid body dynamics: motion, mass, constraint solving, joints, CCD, and so on labels Jan 11, 2025
@Jondolf Jondolf merged commit 6a65e8f into main Jan 11, 2025
5 checks passed
@Jondolf Jondolf deleted the fix-sleeping branch January 11, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Dynamics Relates to rigid body dynamics: motion, mass, constraint solving, joints, CCD, and so on C-Regression Behaviour that was working before is now worse or broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jondolf