Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary cfg_attr from from_shape mass helpers #644

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Remove unnecessary cfg_attr from from_shape mass helpers #644

merged 1 commit into from
Jan 30, 2025

Conversation

Jondolf
Copy link
Owner

@Jondolf Jondolf commented Jan 30, 2025

Objective

Some mass property helpers like Mass::from_shape are currently gated behind the default-collider feature and Parry, even though they don't need these features anymore.

Solution

Remove the feature gates.

@Jondolf Jondolf added A-Dynamics Relates to rigid body dynamics: motion, mass, constraint solving, joints, CCD, and so on C-Usability A quality-of-life improvement that makes Avian easier to use labels Jan 30, 2025
@Jondolf Jondolf enabled auto-merge (squash) January 30, 2025 16:12
@Jondolf Jondolf merged commit be9ebc5 into main Jan 30, 2025
5 checks passed
@Jondolf Jondolf deleted the unnecessary-feature-gate branch January 30, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Dynamics Relates to rigid body dynamics: motion, mass, constraint solving, joints, CCD, and so on C-Usability A quality-of-life improvement that makes Avian easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jondolf