pre-commit replace bandit with ruff #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Replace Bandit with ruff in pre-commit
✨ Context
ruff has reimplemented the bandit rules[1], so it can be use that as a better-integrated tool. So enable all the bandit rules and selectively disable some across the codebase and some in just tests where they don't make sense (e.g. flagging use of assert ).
[1] Per astral-sh/ruff#1646 they've implemented nearly all of them, and the remaining ones aren't that important IMO.
🧠 Rationale behind the change
uses less tools in pre-commit and get rid of the GitPython dependency, lees tools less security holes
Type of changes
🛠 What does this PR implement
remove bandit form pre-commit and replace it using RUff Rules
change unit test to ignore warning detected by ruff
🧪 How should this be tested?
make check
poetry run pytest --cov