Fix IndexOutOfRangeException when a comment line ends on the buffer boundary - #2381
Open
scepion1d wants to merge 1 commit into
Open
Fix IndexOutOfRangeException when a comment line ends on the buffer boundary#2381scepion1d wants to merge 1 commit into
scepion1d wants to merge 1 commit into
Conversation
scepion1d
force-pushed
the
fix/comment-line-buffer-boundary
branch
from
July 1, 2026 09:44
a1717ce to
35a6b05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
CsvParserthrowsSystem.IndexOutOfRangeExceptionwhen parsing a comment (or blank) line whose trailing line ending lands exactly on the read-buffer boundary. It reproduces reliably at comment-line lengths of the formk × BufferSize − 2for power-of-twok(2, 4, 8, …), becauseFillBufferdoubles the buffer when a record outgrows it. Any input with a sufficiently long comment line can hit thisWhat?
src/CsvHelper/CsvParser.cs- InReadLine, a comment/blank line is consumed byReadBlankLine, which reads the line including its\r\n. On the state-machine resume path (after a buffer refill), completion fell through toc = buffer[bufferPosition]without re-checkingbufferPosition < charsRead. When the line ending aligned with the buffer boundary (bufferPosition == charsRead == buffer.Length), this read past the end of the buffer. The fix loops back (continue) when aBlankLinestate completes, so the bound is re-evaluated - mirroring the already-safe fresh-detection path.