ci: fix prettier config to allow for rc file parsing #12
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
| "overrides": [ | ||
| { "files": ".*rc", "options": { "parser": "json" } }, | ||
| { "files": ".nvmrc", "options": { "parser": "yaml" } } | ||
| ], |
There was a problem hiding this comment.
[Question] @michaelfaith I'm confused: when I run npx prettier . --write without these changes, the .all-contributorsrc file does get parsed as JSON and written to properly. So why would this fix things?
|
Super weird. It was failing for me locally at one point, which this resolved. But it isn't now. So I'm not sure what was up with my local. It looks like the real issue was the all-contributors didn't format as part of its PR? |
PR Checklist
status: accepting prsOverview
This #10 revealed a gap in the prettier config. This override adds parsing support for rc files like the all-contributingrc