Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use eslint-fix-utils for element and property removals #750

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 19, 2025

PR Checklist

Overview

Uses the exported APIs added in JoshuaKGoldberg/eslint-fix-utils@6bf5c33.

@michaelfaith I'd love to get your input on this: how does the API feel to you? If you think they should be changed drastically -here and/or in the other repo- I'm definitely up for iterating on them. 🙂

The build failures can be ignored, they're some problem in eslint-fix-utils that I haven't dug into yet. JoshuaKGoldberg/eslint-fix-utils#7

💖

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (29a9722) to head (bd51f89).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   98.01%   97.97%   -0.04%     
==========================================
  Files          18       18              
  Lines        1408     1383      -25     
  Branches      133      132       -1     
==========================================
- Hits         1380     1355      -25     
  Misses         28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: use eslint-fix-utils for element and property removals chore: use eslint-fix-utils for element and property removals Jan 19, 2025
@michaelfaith
Copy link
Collaborator

It definitely saved a fair amount of code in the cast of no-redundant-files, but it didn't really do anything to help us in unique-dependencies. It prevented us from taking advantage of the fact that you can assume the redundant dependency will not be the last element, and thus will always have a comma token after. So it ends up being a wash, in terms of value for that one.

As far as the api surface itself, it seems reasonable from the usage side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Extract element/property removal to a shared package
2 participants