Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colossus: Rework sync and cleanup #5194

Merged
merged 10 commits into from
Jan 10, 2025

Conversation

Lezek123
Copy link
Contributor

@Lezek123 Lezek123 commented Nov 25, 2024

Resolves #5182

  • Optimizations: The way data objects / data object ids are queried and processed during sync and cleanup has been optimized:
    • Sync and cleanup services now process tasks in batches of configurable size (--syncBatchSize, --cleanupBatchSize) to avoid overflowing the memory.
    • Synchronous operations like sort or filter on larger arrays of data objects have been optimized (for example, by replacing .filter(Array.includes(...)) with .filter(Set.has(...))).
    • Enforced a limit of max. results per single GraphQL query to 10,000 and max input arguments per query to 1,000.
    • Added --cleanupWorkersNumber flag to limit the number of concurrent async requests during cleanup.
  • A safety mechanism was added to avoid removing "deleted" objects for which a related DataObjectDeleted event cannot be found in storage squid.
  • Improved logging during sync and cleanup.

@Lezek123 Lezek123 marked this pull request as draft November 25, 2024 18:44
@Lezek123 Lezek123 requested a review from mnaamani November 28, 2024 08:14
@Lezek123 Lezek123 marked this pull request as ready for review November 28, 2024 08:14
@Lezek123 Lezek123 changed the title Colossus: Rework sync and cleanup (WIP) Colossus: Rework sync and cleanup Nov 28, 2024
@Lezek123 Lezek123 requested a review from freakstatic January 7, 2025 10:23
@mnaamani mnaamani merged commit 7144462 into Joystream:master Jan 10, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can't clean files that don't belong to me using the -c parameter
2 participants