Lift bokeh dependency constraint and add test files for newer bokeh version #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in `check_bokeh_plot` fixture
And fixed small bug in `bokeh_spinpol_dos` discovered due to this
Codecov Report
@@ Coverage Diff @@
## develop #122 +/- ##
===========================================
- Coverage 82.26% 82.25% -0.01%
===========================================
Files 131 131
Lines 23794 23798 +4
===========================================
+ Hits 19574 19576 +2
- Misses 4220 4222 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #120 and #121
Previously the bokeh version was fixed to
<=1.4.0. This was due to newer required tornado version (especially >5) which clashed with the version required for aiida-core from it's dependencycircusHowever since aiida-core 1.6.0 this library was updated and no longer requires tornado<5 (Probably even earlier since there was no major version bump so the newer version can probably be used with even earlier versions of aiida-core), meaning we can lift this constraint.
Since this is an optional dependency I think this should be fine to introduce without moving to a new major version