Skip to content

Fix supertype of RFE models. #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ablaom merged 2 commits into from
Apr 6, 2026
Merged

Fix supertype of RFE models. #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81764e1
fix bug to close #34
ablaom Apr 5, 2026
8840a55
bump 0.2.5
ablaom Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "FeatureSelection"
uuid = "33837fe5-dbff-4c9e-8c2f-c5612fe2b8b6"
authors = ["Anthony D. Blaom <anthony.blaom@gmail.com>", "Samuel Okon <okonsamuel50@gmail.com"]
version = "0.2.4"
version = "0.2.5"

[deps]
MLJModelInterface = "e80e1ace-859a-464e-9ed9-23947d8ae3ea"
Expand Down
3 changes: 2 additions & 1 deletion src/models/rfe.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const ERR_FEATURES_SEEN = ArgumentError(
const MODEL_TYPES = [
:ProbabilisticRecursiveFeatureElimination, :DeterministicRecursiveFeatureElimination
]
const SUPER_TYPES = [:Deterministic, :Probabilistic]
const SUPER_TYPES = [:Probabilistic, :Deterministic]
const MODELTYPE_GIVEN_SUPERTYPES = zip(MODEL_TYPES, SUPER_TYPES)

for (ModelType, ModelSuperType) in MODELTYPE_GIVEN_SUPERTYPES
Expand Down Expand Up @@ -181,6 +181,7 @@ function RecursiveFeatureElimination(
# which is rare.
throw(ERR_MODEL_TYPE)
end

message = MMI.clean!(selector)
isempty(message) || @warn(message)
return selector
Expand Down
2 changes: 2 additions & 0 deletions test/models/rfe.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ const DTM = DummyTestModels
selector = RecursiveFeatureElimination(model=rf)
selector2 = RecursiveFeatureElimination(model=rf2)
@test selector isa FeatureSelection.DeterministicRecursiveFeatureElimination
@test selector isa MLJBase.Deterministic
@test selector2 isa FeatureSelection.ProbabilisticRecursiveFeatureElimination
@test selector2 isa MLJBase.Probabilistic
@test MLJBase.constructor(selector) == RecursiveFeatureElimination

# Fit models
Expand Down
Loading