Skip to content

Allow multiplication with different algebras #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow multiplication with different algebras #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d1707
Allow multiplication with different algebras
blegat Jul 3, 2024
8a6e2dd
Fixes
blegat Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/arithmetic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,23 +140,24 @@ function MA.operate_to!(
::typeof(*),
args::Vararg{AlgebraElement,N},
) where {N}
for arg in args
@assert parent(res) == parent(arg)
end
mstr = mstructure(basis(res))
mstr = mstructure(parent(res), parent.(args)...)
MA.operate_to!(coeffs(res), mstr, coeffs.(args)...)
return res
end

function mstructure(args::AbstractStarAlgebra...)
for arg in args
@assert arg == first(args)
end
return mstructure(basis(args[1]))
end

function MA.operate!(
::UnsafeAddMul{typeof(*)},
res::AlgebraElement,
args::Vararg{AlgebraElement,N},
) where {N}
for arg in args
@assert parent(res) == parent(arg)
end
mstr = mstructure(basis(res))
mstr = mstructure(parent(res), parent.(args)...)
MA.operate!(UnsafeAddMul(mstr), coeffs(res), coeffs.(args)...)
return res
end
Expand Down