-
Notifications
You must be signed in to change notification settings - Fork 4
Implement SubBasis #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
638f754
implement SubBasis and SubMStructure
kalmarek 5d8c763
Add broken tests
blegat d76bb23
store indicies instead of elts
kalmarek 79d8a0c
Fix tests
blegat 1eae247
Remove implicit/explicit
blegat 03658f3
Remove FiniteSupportBasis
blegat abffaec
Fixes
blegat 6f83690
Rename fields
blegat f29dc5e
Adding docstrings
blegat b448ad9
Remove unrelated changes
blegat dfa6a79
Fill in docstrings
blegat 3234af5
Add tests
blegat 8c57f1e
Swap fields order
blegat c3e76b5
Update src/bases.jl
blegat c6d6c34
Improve FixedBasis docstring
blegat 1a2d366
Explain why we fix the seed
blegat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kalmarek What would be the difference between a
FiniteSupportBasisand anExplicitBasis? I thought that anExplicitBasiswas a basis with a finite number of elements ^^