Skip to content

Implement addition of subbasis by converting to parent basis #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
blegat wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Implement addition of subbasis by converting to parent basis #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ca6dfb
Implement addition of subbasis by converting to parent basis
blegat Apr 28, 2025
ea4ed44
Fix
blegat Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions test/perm_grp_algebra.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,23 @@
end
@test a ≤ b
end

@testset "Automatic conversion to explicit" begin
a = SA.AlgebraElement([2], SA.StarAlgebra(G, SA.SubBasis([g], db)))
b = SA.AlgebraElement([-3], SA.StarAlgebra(G, SA.SubBasis([h], db)))
# `Base.+` assumes that using the basis of the first argument will suffice
# We should redefine `Base.:+(a::SubBasis, b::SubBasis)` to first
# convert `a` and `b` to their implicit basis equivalent and then
# do `+` and then convert the result back
# `MultivariateBases` defines an `implicit` function.
# Why not having an `explicit` as well ?
# My dream implementation would be
# Base.:+(a::SubBasis, b::SubBasis) = explicit(implicit(a) + implicit(b))
# so we just need to implement `implicit` and `explicit` 👼
@test_broken SA.explicit(SA.implicit(a)) == a
@test_broken SA.explicit(SA.implicit(a)) == a
@test_broken SA.explicit(SA.implicit(b)) == b
@test_broken a + b == SA.explicit(SA.implicit(a) + SA.implicit(b))
@test_broken a * b == SA.explicit(SA.implicit(a) * SA.implicit(b))
end
end