Skip to content

Implement firstindex and lastindex #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blegat wants to merge 1 commit into from
Closed

Implement firstindex and lastindex #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/bases_fixed.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@
Base.in(x::T, b::SubBasis{T}) where T = !isnothing(get(b, x, nothing))
Base.haskey(b::SubBasis, i::Integer) = i in eachindex(b.keys)

Base.firstindex(b::SubBasis) = firstindex(b.keys)
Base.lastindex(b::SubBasis) = lastindex(b.keys)

Check warning on line 142 in src/bases_fixed.jl

View check run for this annotation

Codecov / codecov/patch

src/bases_fixed.jl#L141-L142 

Added lines #L141 - L142 were not covered by tests
Base.getindex(b::SubBasis, i::Integer) = parent(b)[b.keys[i]]
function Base.getindex(b::SubBasis{T,I}, x::T) where {T,I}
i = get(b, x, nothing)
Expand Down
Loading