Skip to content

Conversation

@blegat
Copy link
Member

@blegat blegat commented Jun 14, 2025

This is needed for JuliaAlgebra/MultivariateBases.jl#57.
I'm not sure how it was passing before that PR but looking at the code, it's unclear why we could need += instead of = unless we expect that there are duplicates in cfs and that it's not canonical ? I think we assume that it's always canonicalized unless inside UnsafeAddMul.
Again, let's not merge this right away, I'll check if that's the right fix

@codecov
Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.15%. Comparing base (dd6c877) to head (2a71232).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   84.15%   84.15%           
=======================================
  Files          15       15           
  Lines         871      871           
=======================================
  Hits          733      733           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kalmarek
Copy link
Collaborator

Indeed most probably I wrote this when the issue what and when is canonicalized has not yet been clarified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants