WIP: add unsafe_convert to pointer - #102
Open
oxinabox wants to merge 3 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 89.18% 89.29% +0.10%
==========================================
Files 9 9
Lines 296 355 +59
==========================================
+ Hits 264 317 +53
- Misses 32 38 +6
Continue to review full report at Codecov.
|
mcabbott
reviewed
Apr 1, 2020
Co-Authored-By: Michael Abbott <32575566+mcabbott@users.noreply.github.com>
oxinabox
commented
Apr 4, 2020
Collaborator
|
Bump? |
Member
Author
|
I never ended up needing this, so never wrote tests so can't merge it |
Collaborator
|
Perhaps just this? This passes without the method I suggested, i.e. with only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of trying to get this wo work with distributions