Repeated names - #148
Open
mcabbott wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 93.71% 93.76% +0.04%
==========================================
Files 10 10
Lines 382 385 +3
==========================================
+ Hits 358 361 +3
Misses 24 24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
I know @nickrobinson251 likes for covarience matrixes that indexing with just the keyword gives you on the diagonal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe it's time to define & test the behaviour with repeated indices. This fixes:
sum(A, dims=:i)to use the first dimension named:i, as it already did, andA[i=1]is an error if more than one dimension is named:i. Previously it fixed all such dimensions.The one exception I can think of is that, for a
Diagonalmatrix, it may make sense to index both dimensions together. But maybe I have overlooked other uses?The indexing change did not break any tests. But may still count as a breaking change, not sure.