Skip to content

Run runic formatter - #34

Closed
abhro wants to merge 1 commit into
mainfrom
runic
Closed

Run runic formatter#34
abhro wants to merge 1 commit into
mainfrom
runic

Conversation

@abhro

@abhro abhro commented Jun 13, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.42381% with 328 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.21%. Comparing base (979c149) to head (4b20de7).

Files with missing lines Patch % Lines
src/fitscore.jl 0.00% 87 Missing ⚠️
src/card.jl 81.94% 63 Missing ⚠️
src/hdu/table.jl 54.46% 51 Missing ⚠️
src/hdu.jl 76.56% 45 Missing ⚠️
src/hdu/conform.jl 0.00% 25 Missing ⚠️
src/hdu/bintable.jl 84.55% 21 Missing ⚠️
src/hdu/zimage.jl 0.00% 12 Missing ⚠️
src/hdu/ztable.jl 0.00% 12 Missing ⚠️
src/hdu/random.jl 93.93% 6 Missing ⚠️
src/hdu/primary.jl 91.11% 4 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   46.17%   46.21%   +0.03%     
==========================================
  Files          17       17              
  Lines        2551     2588      +37     
==========================================
+ Hits         1178     1196      +18     
- Misses       1373     1392      +19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@barrettp

Copy link
Copy Markdown
Member

Please don't merge this PR until I have had a chance to review it.

@barrettp

barrettp commented Jul 11, 2026

Copy link
Copy Markdown
Member

I really don't like the Runic formatter in general and some of the formatting specifically, such as removing spaces before equal signs which are meant to align a series of variable definition statements to make it easier to read. I find that code, particularly, a set of constants are easier to read when they are aligned in a tabular format. Runic.jl apparently feels otherwise. It prefers expansive code except when it doesn't. As far as I can tell this formatter has no consistent vision of how code should be formatted.

I now understand why it is a formatter that no one likes.

I am therefore not going to merge this PR.

@barrettp barrettp closed this Jul 11, 2026
@abhro
abhro deleted the runic branch July 11, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants