Skip to content

fix: fix tdim issue - #46

Open
jamesrafe wants to merge 1 commit into
mainfrom
fix/fix-tdim-issue
Open

fix: fix tdim issue#46
jamesrafe wants to merge 1 commit into
mainfrom
fix/fix-tdim-issue

Conversation

@jamesrafe

@jamesrafe jamesrafe commented Jul 26, 2026

Copy link
Copy Markdown

Closes #44

Fix one-dimensional FITS TDIM values such as TDIM=(3). These were parsed as an integer, but BinaryField expects dimensions as a tuple or nothing. The new helper normalizes them to (3,) across all binary-table construction paths and adds tests for the changes.

@jamesrafe
jamesrafe requested a review from barrettp as a code owner July 26, 2026 16:38
@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.77%. Comparing base (870e4ee) to head (11c5a1b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   46.35%   46.77%   +0.41%     
==========================================
  Files          17       17              
  Lines        2550     2555       +5     
==========================================
+ Hits         1182     1195      +13     
+ Misses       1368     1360       -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in handling one-dimensional TDIM values in binary tables

1 participant