Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MultiDocumenter.jl #43

Open
wants to merge 29 commits into
base: source
Choose a base branch
from
Open

Use MultiDocumenter.jl #43

wants to merge 29 commits into from

Conversation

icweaver
Copy link
Member

@icweaver icweaver commented Apr 4, 2025

This PR tries to get MultiDocumenter in the mix next. This is inspired from this old convo

Depends on #40

It seems to be building locally alright for me (pics below), but I am lost when it comes to CI stuff. Any help is appreciated!

Demo

Preview link

https://juliaastro.org/previews/PR43/

Doesn't seem to be reflecting changes yet, I am positive that I must be holding it wrong It's working now, thanks @abhro!

Unified search

image

Topbar links to external package docs

image

Future PR(s)?

  • Sync list of docs in docs/make.jl with pages.jl. Currently doing this manually (WIP here: Simplified MultiDocumenter.jl #44)
  • More informative unified search. Would be cool to prepend the parent package name to search result hits to give them more context

@abhro abhro self-requested a review April 5, 2025 16:46

deploydocs(;
repo = "github.com/JuliaAstro/JuliaAstro.github.io",
push_preview = true,
branch = "master",
devbranch = "source"
devbranch = "multidocumenter",
Copy link
Member

@abhro abhro Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed back to devbranch = "source" before merging?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You read my mind. Wasn't sure how that would play with PR doc previews, but totally happy to switch it back if it looks good to you!

@abhro abhro requested a review from mileslucas April 5, 2025 21:47
@abhro abhro marked this pull request as ready for review April 5, 2025 21:48
@abhro abhro requested a review from giordano April 5, 2025 22:41
@sefffal
Copy link
Member

sefffal commented Apr 7, 2025

Wow @icweaver , this is amazing! Thank you for setting this up!

@icweaver icweaver changed the title Multidocumenter experiment Use MultiDocumenter.jl Apr 9, 2025
Comment on lines +48 to +241
upstream = joinpath(clonedir, "FITSIO"),
path = "FITSIO",
name = "FITSIO",
giturl = "https://github.com/JuliaAstro/FITSIO.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "CFITSIO"),
path = "CFITSIO",
name = "CFITSIO",
giturl = "https://github.com/JuliaAstro/CFITSIO.jl.git",
),
MultiDocumenter.Link(
"mweastwood/CasaCore",
"http://mweastwood.info/CasaCore.jl/stable/",
),
MultiDocumenter.Link(
"emmt/OIFITS",
"https://github.com/emmt/OIFITS.jl",
),
MultiDocumenter.Link(
"aplavin/VLBIData",
"https://github.com/JuliaAPlavin/VLBIData.jl",
),
MultiDocumenter.Link(
"aplavin/Difmap",
"https://github.com/JuliaAPlavin/Difmap.jl",
),
]
),
MultiDocumenter.DropdownNav(
"Cosmology",
[
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "Cosmology"),
path = "Cosmology",
name = "Cosmology",
giturl = "https://github.com/JuliaAstro/Cosmology.jl.git",
),
]
),
MultiDocumenter.DropdownNav(
"Orbits & Ephemerides",
[
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "Transits"),
path = "Transits",
name = "Transits",
giturl = "https://github.com/JuliaAstro/Transits.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "sefffal/PlanetOrbits"),
path = "sefffal/PlanetOrbits",
name = "sefffal/PlanetOrbits",
giturl = "https://github.com/sefffal/PlanetOrbits.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "EarthOrientation"),
path = "EarthOrientation",
name = "EarthOrientation",
giturl = "https://github.com/JuliaAstro/EarthOrientation.jl.git",
),
MultiDocumenter.Link(
"JPLEphemeris",
"https://github.com/JuliaAstro/JPLEphemeris.jl",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "AstroLib"),
path = "AstroLib",
name = "AstroLib",
giturl = "https://github.com/JuliaAstro/AstroLib.jl.git",
),
]
),
MultiDocumenter.DropdownNav(
"Numerical Utilities",
[
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "BoxLeastSquares"),
path = "BoxLeastSquares",
name = "BoxLeastSquares",
giturl = "https://github.com/JuliaAstro/BoxLeastSquares.jl.git",
),
MultiDocumenter.MultiDocRef(
upstream = joinpath(clonedir, "LombScargle"),
path = "LombScargle",
name = "LombScargle",
giturl = "https://github.com/JuliaAstro/LombScargle.jl.git",
),
]
),
MultiDocumenter.DropdownNav(
"Statistics",
[
MultiDocumenter.Link(
"sefffal/PairPlots",
"https://sefffal.github.io/PairPlots.jl/dev",
),
]
),
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit is all manual and gross for now just to stand things up, and can be replaced by something like #44 if we end up wanting to go the "single source of truth" route discussed there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants