Skip to content

Refactor inverse_dict_type #26

Description

@goerz

From @mofeing in #25 (comment):

From my side, one thing left that we should take care of before v1.0.0 is this method:

function inverse_dict_type(D::Type{<:AbstractDict{K,V}}) where {K,V}
@warn "Using the default `inverse_dict_type` for $D. This may not be optimal for your specific dictionary type."
D.name.wrapper{V,K}
end

It does some internal hacking we shouldn't rely on. I added it because it was useful for BijectiveDicts.jl, but now that we are taking it more seriously, we should remove it and write extensions to that method for different dict types.


Might be good to put this into a v1.0.0 milestone to keep track of the things we still want to do before releasing v1.0.0 – it doesn't seem like like I have sufficient access to create milestones

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions