Skip to content

Conversation

@oxinabox
Copy link
Member

@oxinabox oxinabox commented Dec 2, 2020

Reverts #316

brings back #315

Also needs JuliaDiff/FiniteDifferences.jl#125 first
needs #309 first so will need to be rebased on that.

@oxinabox
Copy link
Member Author

oxinabox commented Dec 3, 2020

@sethaxen sethaxen closed this Dec 3, 2020
@sethaxen sethaxen reopened this Dec 3, 2020
@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f550f8d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #317   +/-   ##
=========================================
  Coverage          ?   97.15%           
=========================================
  Files             ?       16           
  Lines             ?      880           
  Branches          ?        0           
=========================================
  Hits              ?      855           
  Misses            ?       25           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f550f8d...04dfc15. Read the comment docs.

@oxinabox
Copy link
Member Author

oxinabox commented Dec 3, 2020

Failing tests are Julia Nightly being broken.
So I am merging this.
Original PR was approved so unreverting it's reversion should be fine

@oxinabox oxinabox merged commit 6eb1027 into master Dec 3, 2020
@oxinabox oxinabox deleted the revert-316-revert-315-ox/testhard branch December 3, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants