-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Robustness and Performance #130
Merged
Merged
Changes from all commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
df62b63
Differentiate between adapted and unadapted FDMs
wesselb f826fa8
Use tuples to store coefs to reduce allocs
wesselb 16ef690
Make grids tuples
wesselb c3dd629
Simplify construction of adapted methods
wesselb 3f1b78b
Add conversions
wesselb d4aa794
Propagate geom keyword and remove redundant method
wesselb b3017f1
Make adaptation part of type and precompute more
wesselb ec78b97
First go at restructuring
wesselb 8e36074
Allow real inputs to extrapolate_fdm
wesselb cb63d6b
Add StaticArrays
wesselb 721bcd5
Rework and use SAs to get zero allocs
wesselb 9bbbda4
Fix tests
wesselb 4fc61e2
Unspaghetti code
wesselb 3d2e44f
Change kw_arg to arg to fix type inference
wesselb 759cceb
Add BenchmarkTools as test dep
wesselb e4bbc21
Add test for allocations
wesselb e96e7e1
Reorganise tests
wesselb 942297a
Loosen very tight tolerances
wesselb e92fb11
Make max_range part of FDM struct
wesselb 9c7cd09
Fix custom grid
wesselb 7c33edf
Loosen tolerance
wesselb ce7147d
Loosen tolerances even more
wesselb 8941d9b
Update src/methods.jl
wesselb 771aabc
Update test/methods.jl
wesselb 1f9b4ae
Update test/methods.jl
wesselb 1036d87
Update src/methods.jl
wesselb a54bec8
Update src/methods.jl
wesselb 579984a
Add comment and simplify line
wesselb e23607e
Merge branch 'wb/robustness-simplify' of github.com:JuliaDiff/FiniteD…
wesselb fb005ef
Add accuracy tests
wesselb 5b8308c
Limit samples and evals in test
wesselb 257f12e
Fix test
wesselb 12813db
Add method for SVector
wesselb 5c97c51
Fix docs
wesselb 22802a4
Use big to allow very high orders
wesselb 23357dc
Extend documentation
wesselb 584b963
Add sentence about allocations
wesselb 7dd8944
Update multivariate examples
wesselb fbff4f9
Tighten accuracy tests
wesselb d2f8036
Adjust tolerances
wesselb 0fa0b20
Loosen test for cosc
wesselb 76f9ccb
Fix exception for cosc
wesselb 8076594
Fix typos
wesselb 0b67236
Tighten separate test for cosc
wesselb dfbdd74
Remove separate tests
wesselb 1cda212
Remove caret
wesselb 5f22b5a
Fix Manifest.toml for docs
wesselb d4e74eb
Rename internal function
wesselb 55863b0
Adjust spacing to clarify
wesselb f49540d
Fix typo
wesselb 29dd0e0
Fix style issues
wesselb c385695
Fix 1.0 compatibility
wesselb 48a15d0
Fix docs
wesselb deecc5e
Generalise method
wesselb 91db8cb
Fix docs
wesselb 4d0b31e
Fix docstring
wesselb 1b3d512
Increase minor version
wesselb fa79848
Merge branch 'master' into wb/robustness-simplify
wesselb 7672c63
Remove weird indent
wesselb cfbe4a1
Use ballocated
wesselb d7cc43d
Clarify wording around contraction rate
wesselb 9bcb2d2
Automatically update index.md in docs
wesselb d6d14ef
Clarify example in README
wesselb be06452
Update comparison with FiniteDiff
wesselb 0058b46
Update src/methods.jl
wesselb e69d7e2
Document return value of NaN in estimate_step
wesselb 9012b7e
Update src/methods.jl
wesselb 0d67075
Update src/methods.jl
wesselb b893bc1
Improve comments
wesselb 88029f1
Update src/methods.jl
wesselb ec27a2b
Update src/methods.jl
wesselb 418b48e
Fix spacing and capitalise
wesselb 02b7f37
Elaborate on coefs_neighbourhood
wesselb 8146fae
Do not store docs/src/index.md in repo
wesselb 3cf218f
Fix docstring
wesselb 85a7f95
Update src/methods.jl
wesselb 5c363ec
Fix typo
wesselb 7ae587a
Merge branch 'master' into wb/robustness-simplify
wesselb 9be39b8
Remove compat entry to allow ChainRules int. test
wesselb 0e29e4c
Revert "Remove compat entry to allow ChainRules int. test"
wesselb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
*.jl.cov | ||
*.jl.*.cov | ||
*.jl.mem | ||
/Manifest.toml | ||
|
||
# Docs: | ||
docs/build/ | ||
docs/site/ | ||
/Manifest.toml | ||
# `docs/src/index.md` will be automatically generated by `docs/make.jl`. | ||
docs/src/index.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,24 @@ | ||
name = "FiniteDifferences" | ||
uuid = "26cc04aa-876d-5657-8c51-4c34ba976000" | ||
version = "0.11.7" | ||
version = "0.12.0" | ||
|
||
[deps] | ||
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4" | ||
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" | ||
Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7" | ||
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" | ||
Richardson = "708f8203-808e-40c0-ba2d-98a6953ed40d" | ||
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" | ||
|
||
[compat] | ||
ChainRulesCore = "0.9" | ||
Richardson = "1.2" | ||
julia = "1" | ||
|
||
[extras] | ||
BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf" | ||
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" | ||
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" | ||
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
|
||
[targets] | ||
test = ["Random", "StaticArrays", "Test"] | ||
test = ["Random", "Test", "BenchmarkTools"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this breaking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured that a minor version increase was warranted because the internals now work very differently, which affects the behaviour of the estimates (hopefully in a good way). One breaking change is that the keyword argument
max_step
is removed.