Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72.
Now we are faster than we were even on 0.9.2 before I made it slow.
This does part of #61 in particular part of this comment
#61 (comment)
Looks like the cause was #65.
Am going to build a fix shortly
First two timings are as per #72 (comment)
v0.9.5
v0.9.2
With this PR
Using timing from #61
We get:
v0.9.5
v0.9.2
With this PR
Explain
I think the main reason why this gives much more improvement in the test case from #72 than from #61, is that the #61 benchmark declares the fdm objects outside the the hot-loop.
And that is where
_coeffs
are calculated.Except I think they are also calculated when
adapt
is triggered.So this helps more there for the
_fdm5
case.